[#1760] Edit Project Name - SCSS to Styled Components #1806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release Environmentsp5.js-web-editor |
|
Seems like the only component I worked on have tests integrated. What are the odds! |
|
@catarak I looked into the test. I think jest tests are receiving undefined while accessing theme on using prop function. Do you have any idea about this? |
|
Fixed it. The test was not able to access the theme, so I wrapped the component with Ready for the review :) |
|
I have also added PR #1808 to ensures that any calls to render have a theme available. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Fixes #1760
Project NamefromToolbarinto a new component for reusability in the future i.e. For the mobile version.Project Namerelated SCSS to Styled Components.theme.jsToolbarfrom class-based to the functional component asToolbardoes not have any state.I have verified that there is no change in UI and it's working.
Before:
After:
I have verified that this pull request:
npm run lint)developbranch. (If I was asked to make more changes, I have made sure to rebase ontodevelopthen too)Fixes #123